Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-47551 SF: run ant format-source #4

Closed
wants to merge 640 commits into from

Conversation

mdelapenya
Copy link

Hey Miro, Bobo browser does not support null Sorts when browsing the index (I sent them a pull here senseidb/bobo#21). Could you see it the NULL_SORT can be changed? Or is it necessary?

If the _NULL_SORT is present, then the error is a NPE on Bobo classes. If we use a non-null Sort object, then the failure is on our side, but the on the asserts.

Thanks!

shuyangzhou and others added 30 commits December 15, 2014 12:21
…ule, but do @DeleteAfterTestRun, cut down run time from 9sec to 1sec
…lk pk fetch rather than individual service layer fetch, to reduce aop boundaries accessing
Prefer adding variables in Liferay namespace instead to create
more global variables. themeDisplay (which pattern was followed here)
was created probably for performance issues in the past when accessing
properties like this - "prop1.prop2.prop3" was slow.
For many years it is not anymore and adding global variables only polutes
the global namespace, nothing else.
…work to place into registry for multiple interfaces
brianchandotcom and others added 24 commits December 19, 2014 14:57
…ploy will not be considered uptodate unless jar is, which will not be considered uptodate unless compile is)
…each group. Even Guest and personal sites need the individual resource permission record
@mdelapenya mdelapenya force-pushed the LPS-47551-user-search branch from 0000000 to 8496ccd Compare December 22, 2014 13:28
@ligasm
Copy link
Owner

ligasm commented Dec 22, 2014

I used the _NULL_SORT as the easiest to get default value. I think it should be possible to substituent it with a default sort object.

@ligasm
Copy link
Owner

ligasm commented Dec 22, 2014

I tried quickly fix the test with some other default values but I failed. The test would need to be adopted BUT I need to know what's the expected default behaviour?
The API states that the Sort parameter can be null and is optional. If the parameter does not support null any more then the API JavaDoc should be changed but I don't think that it can be changed without deprecation phase even though only the contract is changing.
Please advice what shell I do?

@mdelapenya
Copy link
Author

Hey @ligasm, I have some ideas, I'm closing it and resending (hopefully) today.

Sorry for the delay, I was on holiday!

@mdelapenya mdelapenya closed this Jan 12, 2015
@mdelapenya mdelapenya deleted the LPS-47551-user-search branch January 12, 2015 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.