-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-47551 SF: run ant format-source #4
Conversation
…ule, but do @DeleteAfterTestRun, cut down run time from 9sec to 1sec
This reverts commit 55a9db1.
…om parent organizations
…lk pk fetch rather than individual service layer fetch, to reduce aop boundaries accessing
…and Control panel is cut off
…void hardcode them
Prefer adding variables in Liferay namespace instead to create more global variables. themeDisplay (which pattern was followed here) was created probably for performance issues in the past when accessing properties like this - "prop1.prop2.prop3" was slow. For many years it is not anymore and adding global variables only polutes the global namespace, nothing else.
…work to place into registry for multiple interfaces
…7Delete() into test04UTF8()
…ll() into test10Col()
…ploy will not be considered uptodate unless jar is, which will not be considered uptodate unless compile is)
…each group. Even Guest and personal sites need the individual resource permission record
… key must be root portlet ID
…mbers of the parent site" is enabled.
… it will be a sort criteria
0000000
to
8496ccd
Compare
I used the _NULL_SORT as the easiest to get default value. I think it should be possible to substituent it with a default sort object. |
I tried quickly fix the test with some other default values but I failed. The test would need to be adopted BUT I need to know what's the expected default behaviour? |
Hey @ligasm, I have some ideas, I'm closing it and resending (hopefully) today. Sorry for the delay, I was on holiday! |
Hey Miro, Bobo browser does not support null Sorts when browsing the index (I sent them a pull here senseidb/bobo#21). Could you see it the NULL_SORT can be changed? Or is it necessary?
If the _NULL_SORT is present, then the error is a NPE on Bobo classes. If we use a non-null Sort object, then the failure is on our side, but the on the asserts.
Thanks!